Skip to content

Compatibility50: Backport objc_getClass hook patch. #27036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2019
Merged

Compatibility50: Backport objc_getClass hook patch. #27036

merged 1 commit into from
Sep 5, 2019

Conversation

jckarter
Copy link
Contributor

@jckarter jckarter commented Sep 5, 2019

We don't want older runtimes trying to chase rogue symbolic references through objc_getClass
either. rdar://problem/55036306

@jckarter
Compatibility50: Backport objc_getClass hook patch.
624ad4f 
We don't want older runtimes trying to chase rogue symbolic references through objc_getClass
either. rdar://problem/55036306
@jckarter jckarter requested a review from mikeash September 5, 2019 17:48
@jckarter
Copy link
Contributor Author

jckarter commented Sep 5, 2019

@swift-ci Please test

mikeash
mikeash approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@mikeash mikeash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, glad you decided to do this instead of just limiting the test like I suggested!

@jckarter jckarter merged commit 7897ab8 into swiftlang:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash mikeash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckarter @mikeash