Reflection: Make RemoteRef template not depend on Runtime. #27274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only thing the Runtime affects is the width of the StoredPointer for the remote address, for which storing a uint64_t ought to be enough for anyone we care about so far. This will make it easier to store and use RemoteRefs in code that isn't or shouldn't ideally be templatized on Runtime (such as TypeRefBuilder, and ultimately ReflectionContext, from the Reflection library.)
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test OS X |
Resolving a direct relative reference given a RemoteRef doesn't need the MetadataReader, since the offset should already be in the local buffer; we can add it to RemoteRef's saved remote address and get a new remote address. Refactor the API to make as much as possible of it available directly on RemoteRef.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only thing the Runtime affects is the width of the StoredPointer for the remote address, for
which storing a uint64_t ought to be enough for anyone we care about so far. This will make it
easier to store and use RemoteRefs in code that isn't or shouldn't ideally be templatized on
Runtime (such as TypeRefBuilder, and ultimately ReflectionContext, from the Reflection library.)