Skip to content

[Parse] Assert that the children of syntax tree nodes have contiguous source ranges #27406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2019
Merged

[Parse] Assert that the children of syntax tree nodes have contiguous source ranges #27406

merged 1 commit into from
Sep 28, 2019

Conversation

nathawes
Copy link
Contributor

@nathawes nathawes commented Sep 27, 2019 •
edited
Loading

Also fix the places the new assertion was being hit. This should help us catch syntax tree round-tripping issues earlier going forward.

The assertion is currently failing on some of the SIL tests, but that should go away once #27377 lands.

@nathawes nathawes requested a review from rintaro September 27, 2019 18:42
@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 273ba9d08ae34fa4df1ca54001ba4201da853d8b

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 273ba9d08ae34fa4df1ca54001ba4201da853d8b

[Parse] Assert that the children of syntax tree nodes have contiguous…
f1a2134 
… source ranges

This should help us catch syntax tree round-tripping issues.
@nathawes nathawes force-pushed the add-syntax-range-assertions branch from 273ba9d to f1a2134 Compare September 27, 2019 23:02
@rintaro
Copy link
Member

rintaro commented Sep 28, 2019

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 273ba9d08ae34fa4df1ca54001ba4201da853d8b

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 273ba9d08ae34fa4df1ca54001ba4201da853d8b

rintaro
rintaro approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you Nathan!

@rintaro rintaro merged commit 325204b into swiftlang:master Sep 28, 2019
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Merge pull request swiftlang#27406 from nathawes/add-syntax-r…
9fa1760 
…ange-assertions"

This reverts commit 325204b, reversing
changes made to 066bb61.
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Revert "Merge pull request swiftlang#27406 from nathawes/add-…
27d6e18 
…syntax-range-assertions""

This reverts commit 9fa1760.
@rintaro rintaro mentioned this pull request Oct 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathawes @swift-ci @rintaro