swift-reflection-dump: ELF ObjectMemoryReader support for relocations #27532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collect the relative and symbol relocations from ELF images in order to resolve pointer values read from disk. This allows us to enable symbolic-referencing-all-the-things for ELF platforms.
|
@swift-ci Please test |
|
@davezarzycki Would you be able to test whether this works for you on your Fedora box? Instead of hardcoding specific relocation types I tried to use LLVM's queries as much as possible, so this is hopefully more resilient to non-x86 platforms or linker behavior variations. |
davezarzycki
approved these changes
Oct 4, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect the relative and symbol relocations from ELF images in order to resolve pointer values
read from disk. This allows us to enable symbolic-referencing-all-the-things for ELF platforms.