[SyntaxParse] Fix crashers for generic parameter with attributes #27544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to crash for: Attribute without its name (e.g. Foo<@>) Missing name with attributes (e.g. Foo<@available(*, unavailable)> - Synthesize identifier token so that the SyntaxParsingContext can successfully construct the Attribute syntax. - Don't throw away the parsed attributes if the parameter name is missing. Instead, construct GenericParamater syntax anyway, and handle it in ASTGen.
nathawes
approved these changes
Oct 4, 2019
|
@swift-ci Please smoke test |
rintaro
added a commit
to rintaro/swift
that referenced
this pull request
Oct 14, 2019
…xparse-attrincomplete"" This reverts commit 6f4dc25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to crash for:
Attribute without its name (e.g.
Foo<@>)Missing name with attributes (e.g.
Foo<@available(*, unavailable)>SyntaxParsingContextcan successfully construct theAttributesyntax.GenericParamatersyntax anyway, and handle it inASTGen.