Skip to content

SIL: Final methods need a subclass scope if they override something [5.1] #27874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2019
Merged

SIL: Final methods need a subclass scope if they override something [5.1] #27874

merged 1 commit into from
Oct 25, 2019

Conversation

slavapestov
Copy link
Contributor

... otherwise we compute the wrong visibility in IRGen.

Fixes rdar://problem/55559104.

@slavapestov
SIL: Final methods need a subclass scope if they override something
54e0ff5 
... otherwise we compute the wrong visibility in IRGen.

Fixes <rdar://problem/55559104>.
@slavapestov slavapestov requested a review from a team as a code owner October 25, 2019 00:16
@slavapestov
Copy link
Contributor Author

@jckarter Mind taking a look?

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@edymtt edymtt merged commit b368b0d into swiftlang:swift-5.1-branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkremenek tkremenek tkremenek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slavapestov @tkremenek @edymtt