ICU: Update to version 65.1 on Linux #27937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Please don't merge this until CI has been updated to newer version. |
|
I'm confused; aren't we building this? Is there still a configuration in which we rely on the ICU on the node? |
|
That was to @shahmishal |
|
We use the update-checkout script for PR testing, and for CI we use Jenkins plugin to checkout branches. |
|
@shahmishal is there any update on when this can go in? thanks |
|
@swift-ci test |
This was referenced Nov 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the ICU library used by Linux from 61.1 to 65.1
Major ICU releases seem to come out in October and March so this would be good to get into 5.2, the current version is from March 2018.
The tests in PR swiftlang/swift-corelibs-foundation#2535 have been updated and also work correctly when run against native Foundation on Catalina.