Skip to content

[NFC] Drop More Type Checkers #28179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Nov 11, 2019
Merged

[NFC] Drop More Type Checkers #28179

merged 13 commits into from
Nov 11, 2019

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Nov 10, 2019

  • Remove ConstraintSystem's TypeChecker
  • Make a bunch of TypeChecker things dependent on constraint systems utilities
  • Requestify FunctionBuilderClosurePreCheck to remove a cache from TypeChecker
  • Move preCheckExpression to ConstraintSystem

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 10, 2019

@swift-ci please smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 10, 2019

@swift-ci please test source compatibility

@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 10, 2019

The remaining non-essential state is going to be gone after #28173

@CodaFi CodaFi force-pushed the destroyer-of-hearts branch from e06f6c1 to 1b75dbd Compare November 10, 2019 23:37
@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 10, 2019

@swift-ci please smoke test

@CodaFi CodaFi mentioned this pull request Nov 11, 2019
Merged
@CodaFi
Copy link
Contributor Author

CodaFi commented Nov 11, 2019

⛵️

@CodaFi CodaFi merged commit 852585e into swiftlang:master Nov 11, 2019
@CodaFi CodaFi deleted the destroyer-of-hearts branch November 11, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CodaFi