Skip to content

[test] Adjust SwiftNativeNSBase conditions #28364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

lorentey
Copy link
Member

Adjust the conditions on the SwiftNativeNSBase test so that it runs when testing with the stdlib built directly from this repository.

rdar://problem/50413373

@lorentey lorentey requested a review from Catfish-Man November 19, 2019 22:13
@lorentey
Copy link
Member Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 41cf1e7

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 41cf1e7

@lorentey
Copy link
Member Author

Failures are unrelated.

/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/test/Frontend/crash-in-user-code.swift:5:11: error: CHECK: expected string not found in input
15:45:17 // CHECK: Stack dump:
15:45:17           ^
15:45:17 <stdin>:1:1: note: scanning from here
15:45:17 SOURCE_DIR/test/Frontend/crash-in-user-code.swift:15:2: warning: expression of type 'Int' is unused
15:45:17 ^
15:45:17 <stdin>:1:87: note: possible intended match here
15:45:17 SOURCE_DIR/test/Frontend/crash-in-user-code.swift:15:2: warning: expression of type 'Int' is unused
15:45:17                                                                                       ^

@lorentey
Copy link
Member Author

The failure was addressed in #28373; retrying.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey
Copy link
Member Author

¯_(ツ)_/¯

/home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/llvm-project/llvm/lib/Support/PrettyStackTrace.cpp:57:39: error: implicit instantiation of undefined template 'std::atomic<unsigned int>'
15:30:49 static volatile std::atomic<unsigned> GlobalSigInfoGenerationCounter =
15:30:49                                       ^
15:30:49 /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/atomic_base.h:126:12: note: template is declared here
15:30:49     struct atomic;
15:30:49            ^
15:30:49 1 error generated.

@lorentey
Copy link
Member Author

@swift-ci test

Copy link
Contributor

@Catfish-Man Catfish-Man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lorentey
Copy link
Member Author

lorentey commented Dec 3, 2019

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 31370df into master Dec 3, 2019
@compnerd compnerd deleted the all-your-nsbase branch May 31, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants