Skip to content

Revert "[FrontEnd] Pretty stack trace indicating running user code" #28373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2019
Merged

Revert "[FrontEnd] Pretty stack trace indicating running user code" #28373

merged 1 commit into from
Nov 19, 2019

Conversation

shahmishal
Copy link
Member

@shahmishal shahmishal commented Nov 19, 2019 •
edited
Loading

Reverts #28284

We are seeing test failure on ci.swift.org

https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator/2612/console

14:42:32 ********************
14:42:32 Failing Tests (1):
14:42:32     Swift(iphonesimulator-i386) :: Frontend/crash-in-user-code.swift

@shahmishal
Copy link
Member Author

cc: @tapthaker

@shahmishal shahmishal merged commit ff80326 into master Nov 19, 2019
@shahmishal shahmishal deleted the revert-28284-SR-11765-pretty-stack-trace branch November 19, 2019 23:40
@tapthaker
Copy link
Contributor

Thanks for letting me know. Will revert and fix it.

@lorentey lorentey mentioned this pull request Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanhaskins harlanhaskins Awaiting requested review from harlanhaskins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahmishal @tapthaker