[AutoDiff] Move dumpActivityInfo to DifferentiableActivityInfo class #28597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgogul
force-pushed
the
dump_activity_info
branch
from
f3f7af1 to
8908f15
Compare
bgogul
force-pushed
the
dump_activity_info
branch
from
8908f15 to
0d62e3c
Compare
|
@swift-ci please test tensorflow |
dan-zheng
reviewed
Dec 5, 2019
include/swift/SILOptimizer/Analysis/DifferentiableActivityAnalysis.h
Outdated
Show resolved
Hide resolved
dan-zheng
approved these changes
Dec 5, 2019
|
@swift-ci please test tensorflow |
rxwei
reviewed
Dec 5, 2019
| s << "] " << value; | ||
| } | ||
|
|
||
| void DifferentiableActivityInfo::dump(SILFunction &fn, |
There was a problem hiding this comment.
The function argument is unnecessary. getFunction() gives you the function.
|
@swift-ci please test tensorflow |
|
Tests pass. I will go ahead and merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor refactoring as part of https://bugs.swift.org/browse/TF-993