[Diagnostics] Upon keypath result contextual mismatch try to match ob… #28770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject types If there was a mismatch between last component type and contextual key path result type, let's try to re-match the types with all optionals stripped off. In cases where the problem is optionality difference e.g. `[Int] vs. [Int]?` that propagates contextual information to the last component which facilitates better diagnostics. Resolves: rdar://problem/57843297
|
@swift-ci please smoke test |
hborla
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ject types
If there was a mismatch between last component type and contextual
key path result type, let's try to re-match the types with all optionals
stripped off. In cases where the problem is optionality difference
e.g.
[Int] vs. [Int]?that propagates contextual information tothe last component which facilitates better diagnostics.
Resolves: rdar://problem/57843297