[AutoDiff] flag for cross-file derivative registration #28891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcrasi
force-pushed
the
cross-file-derivative-registration
branch
from
5ef62d8 to
b4a8aac
Compare
dan-zheng
approved these changes
Dec 20, 2019
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since cross-file derivative registration requires a lot of distinct fixes and tests (some of which are drafted in #28790), it would be nice to be able to develop it on
tensorflowunder a flag.This PR adds a flag and a very tiny testcase -- the only situation that I'm aware of that currently works without any of the fixes.