Skip to content

[Build System: build-script] Adds a new xcrun module to build_swift. #29315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2020

Conversation

Rostepher
Copy link
Contributor

This new module replaces the existing module from swift_build_support and is fully tested (including for Python 3).

…hich replaces the existing module from swift_build_support.

This new module uses the build_swift.shell.ExecutableWrapper API to create a wrapper class around 'xcrun'. The wrapper class is instantiated and exposed under the name build_swift.wrappers.xcrun.
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@Rostepher Rostepher merged commit 0405cb5 into swiftlang:master Jan 20, 2020
@Rostepher Rostepher deleted the xcrun-module branch January 20, 2020 03:41
@davezarzycki
Copy link
Contributor

This broke Fedora Linux (perhaps a python 2.7 versus 3 bug?)

FAIL: Swift(linux-x86_64) :: Python/build_swift.swift (510 of 12463)
******************** TEST 'Swift(linux-x86_64) :: Python/build_swift.swift' FAILED ********************
Script:
--
: 'RUN: at line 10';   /usr/bin/python2.7 /home/dave/s/u/swift/utils/build_swift/run_tests.py
--
Exit Code: 1

Command Output (stderr):
--
Traceback (most recent call last):
  File "/home/dave/s/u/swift/utils/build_swift/run_tests.py", line 19, in <module>
    import argparse
  File "/home/dave/s/u/swift/utils/build_swift/argparse/__init__.py", line 18, in <module>
    
ImportError: cannot import name ArgumentDefaultsHelpFormatter

--

@davezarzycki
Copy link
Contributor

Never mind. This seems to be some kind of compiled python cache bug that goes away after git clean -fdx. I wish this cache was kept in the build directory instead of the source directory, but I digress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants