[Constraint solver] Always produce optional types for '?' patterns. #29855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test compiler performance |
|
Compilation-performance test failed |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test compiler performance |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test compiler performance |
|
@swift-ci please test source compatibility |
|
Compilation-performance test failed |
|
This is subsumed by the general PR to generate constraints for patterns, #29879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a type from an optional some pattern (
e.g., x?), the type is always an optional type. Form that optional type rather than an otherwise-meaningless type variable.