IRGen: Separate the concept of "metadata should be cached" from "statically referenced" #30036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ically referenced" Some metadata may require instantiation, but not in a way that requires us to put an additional cache layer in front of it. `Self` metadata is also trivial to access from the local cache, but isn't statically referenceable. Split these concepts and update code to use one or the other appropriately. This catches an issue with metadata prespecialization where it would try to make records for dynamic `Self` incorrectly.
|
@swift-ci Please test |
nate-chandler
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some metadata may require instantiation, but not in a way that requires us to put an additional
cache layer in front of it.
Selfmetadata is also trivial to access from the local cache, butisn't statically referenceable. Split these concepts and update code to use one or the other
appropriately. This catches an issue with metadata prespecialization where it would try to
make records for dynamic
Selfincorrectly.