Skip to content

[NFC] Abstracting isStdlibType and isStdLibDecl logic into Type and Decl #30115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2020
Merged

[NFC] Abstracting isStdlibType and isStdLibDecl logic into Type and Decl #30115

merged 1 commit into from
Feb 28, 2020

Conversation

LucianoPAlmeida
Copy link
Contributor

Currently, this isStdlibType logic is implemented in two places, so this just abstracts the logic in one place as TypeBase method.

cc @slavapestov

slavapestov
slavapestov approved these changes Feb 28, 2020
View reviewed changes
@xedin
Copy link
Contributor

xedin commented Feb 28, 2020

@swift-ci please smoke test

@xedin
Copy link
Contributor

xedin commented Feb 28, 2020

@swift-ci please smoke test

@xedin xedin merged commit 389e84f into swiftlang:master Feb 28, 2020
@LucianoPAlmeida LucianoPAlmeida deleted the nfc-abstract-is-stdlib branch February 28, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPAlmeida @xedin @slavapestov