Revert "[SourceKit] don't install libdispatch and libBlocksRuntime twice, outside of Mac/Windows" #30643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice, outside of Mac/Windows"
|
@swift-ci test |
|
@swift-ci smoke test |
compnerd
approved these changes
Mar 25, 2020
|
@swift-ci please test Windows platform |
|
Just noticed this revert of my pull: can you explain what exactly is failing, since obviously it passed the linux CI? |
|
IIRC it couldn't find those two libraries anymore. I don't know why the Linux build passed on the PR, but other builds failed until this was reverted. |
|
Can you point me at which builds failed and what error you saw? If it's this one, it long predates this pull and continues now. |
|
Sorry, I don't have the specific build anymore. It was complaining that |
|
Alright, I'll try another version of the reverted pull and see if I can reproduce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30096
This is causing builds on Linux to fail.