Skip to content

[Diags-Experimental-Formatting] Misc. design/UX updates #31213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Apr 22, 2020

  • Bold diagnostic message text
  • Change line numbers and file header to unbolded cyan color to emphazize code snippets/message text
  • More compact printing of a single message with unknown location
  • If a diagnostic includes excerpts from multiple files, horizontally align the line numbers
  • Indent filenames with '=' so they appear to the right of line numbers

Screen Shot 2020-04-22 at 1 24 47 PM

- Bold diagnostic message text
- Change line numbers and file header to unbolded cyan color to emphazize code snippets/message text
- More compact printing of a single message with unknown location
- If a diagnostic includes excerpts from multiple files, horizontally align the line numbers
- Indent filenames with '=' so they appear to the right of line numbers
@owenv
Copy link
Contributor Author

owenv commented Apr 22, 2020

@swift-ci smoke test

Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CodaFi
Copy link
Contributor

CodaFi commented Apr 23, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants