[Property Wrappers] Only re-write assign_by_wrapper to assignment if all fields have been initialized. #31248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
slavapestov
reviewed
Apr 24, 2020
| // Only re-write assign_by_wrapper to assignment if all fields have been | ||
| // initialized. | ||
| if (isa<AssignByWrapperInst>(Use.Inst) && | ||
| getAnyUninitializedMemberAtInst(Use.Inst, 0, |
There was a problem hiding this comment.
Do you still need the isFullyUninitialized check above? Unless I'm missing something, it seems like "property wrapper is uninitialized" would be a special case of "any field uninitialized".
There was a problem hiding this comment.
That case is still needed for non-property-wrapped properties
There was a problem hiding this comment.
Sounds like we need to use assign_by_wrapper for everything then, but maybe not in this PR :-)
slavapestov
reviewed
Apr 24, 2020
if all fields have been initialized.
slavapestov
approved these changes
Apr 24, 2020
hborla
force-pushed
the
property-wrapper-di
branch
from
6cb305c to
3aabdb5
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the wrapped property's setter will be called with the potential to access uninitialized memory via observers.
Resolves: rdar://problem/60832285, rdar://problem/58312953
Resolves: SR-12341