[NFC] [SIL] [Parser] Move SILParser into SILParser.h #31255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
force-pushed
the
sil-parser/sil-parser-header
branch
from
af9cc8f to
4c86b7a
Compare
|
I should also mention that I ran both changes through clang-format. |
gottesmm
reviewed
Apr 24, 2020
lib/SIL/Parser/SILParser.h
Outdated
| //===----------------------------------------------------------------------===// | ||
|
|
||
| namespace swift { | ||
| namespace syntax { |
There was a problem hiding this comment.
Can you change this namespace addition to silparser?
zoecarver
force-pushed
the
sil-parser/sil-parser-header
branch
2 times, most recently
from
889328b to
7f13b95
Compare
Moves the declaration of SILParser into a new private header file: SILParser.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the declaration of SILParser into a new private header file: SILParser.h. This is a simple cut and paste so there should be no functional changes.
Based on #31254.