Skip to content

[5.3] Fix ReactiveKit failure seen in source compatibility suite #31290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2020
Merged

[5.3] Fix ReactiveKit failure seen in source compatibility suite #31290

merged 2 commits into from
Apr 25, 2020

Conversation

beccadax
Copy link
Contributor

Cherry-picks #31288 to 5.3.

One of the commits in #31196 caused a regression when canImport() was used to test the importability of a module which has module interfaces for other targets, but not the current one. In practice, this happens with Combine and other iOS 13-introduced modules, because they don't have module interface files for 32-bit ARM.

The right solution is to refactor diagnosis during module loading so that we can guarantee that canImport() won't diagnose anything, but this PR simply adds a similar test case and reverts the commit to fix the broken bot.

Fixes rdar://62335415.

beccadax added 2 commits April 24, 2020 14:06
@beccadax
Add test case for failure seen in source compat suite
afaefd6 
Master source compat suite job swiftlang#4912 failed to build ReactiveKit because Combine does not have an interface for older iOS architectures that were retired before it was released, and a change to module loading diagnosis started to consider switfinterfaces. Add a test case that covers this situation.
@beccadax
Revert "[ModuleLoader] Emit a better diagnostic for swiftinterfaces w…
5fab5b5 
…ith wrong arch."

This reverts commit 412ee0a.
@beccadax beccadax added the r5.3 label Apr 24, 2020
@beccadax
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5fab5b5

@beccadax
Copy link
Contributor Author

@swift-ci please test macOS platform

@beccadax beccadax merged commit 177b62d into swiftlang:release/5.3 Apr 25, 2020
@beccadax beccadax deleted the reacting-to-reactivekit-5.3 branch April 25, 2020 07:45
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beccadax @swift-ci @AnthonyLatsis