Skip to content

[SourceKit] Fix unreachable hit in DocumentStructureWalker #31299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

[SourceKit] Fix unreachable hit in DocumentStructureWalker #31299

merged 1 commit into from
Apr 27, 2020

Conversation

nathawes
Copy link
Contributor

DocumentStructureWalker is calling getObjCSelector which calls isObjc() which eventually triggers name lookup, which is unsupported within ifconfig ranges.

Resolves rdar://problem/61967092

@nathawes nathawes requested a review from akyrtzi April 24, 2020 22:50
@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 43eceef

@nathawes
Copy link
Contributor Author

@swift-ci please test OS X Platform

@nathawes nathawes merged commit 974f8c7 into swiftlang:master Apr 27, 2020
@nathawes nathawes deleted the fix-syntactic-request-crasher branch April 27, 2020 17:05
@nathawes nathawes mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi akyrtzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathawes @swift-ci @akyrtzi