Skip to content

[overlay] Remove unnecessary Optional unwrapping #31687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2020
Merged

[overlay] Remove unnecessary Optional unwrapping #31687

merged 1 commit into from
May 13, 2020

Conversation

ApolloZhu
Copy link
Contributor

Now we pass NSOrthography? directly to a function that takes NSOrthography? without doing any additional work.

If indeed this breaks nothing, I'll sync it to Foundation by making another PR.

@CodaFi
Copy link
Contributor

CodaFi commented May 10, 2020

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 6ba3bc7

@CodaFi
Copy link
Contributor

CodaFi commented May 11, 2020

@swift-ci test Linux

@CodaFi
Copy link
Contributor

CodaFi commented May 11, 2020

You should submit a patch to corelibs regardless. This patch will require Foundation's approval.

@millenomi
Copy link
Contributor

Approved.

@millenomi millenomi merged commit d8f5b20 into swiftlang:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants