[AutoDiff] NFC: garden differentiation transform. #32770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename "emitters" to "cloners", for consistency:
- `JVPEmitter` -> `JVPCloner`
- `VJPEmitter` -> `VJPCloner`
- `PullbackEmitter` -> `PullbackCloner`
Improve `PullbackCloner` documentation.
- Document previously undocumented methods.
- Update outdated documentation.
- For adjoint value accumulation helpers: rename "buffer access" occurrences to
"address". Pullback generation no logner uses buffer accesses (`begin_apply`).
dan-zheng
force-pushed
the
autodiff-gardening
branch
from
efb7170 to
142f205
Compare
rxwei
approved these changes
Jul 8, 2020
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "emitters" to "cloners", for consistency with the rest of the codebase:
JVPEmitter->JVPClonerVJPEmitter->VJPClonerPullbackEmitter->PullbackClonerImprove
PullbackClonerdocumentation."address". Pullback generation no longer uses buffer accesses (
begin_apply).Prep for SR-13182: using the pointer-to-impl pattern to minimize derivative function cloner
header files. It's nice to first finalize the header file locations.