Unicode experimentation #32925
Closed
Unicode experimentation #32925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Linux platform |
|
Ooooh... This is exciting! |
|
Build failed |
|
Please test with following PRs: @swift-ci please test Linux platform |
|
Build failed |
@tbkka made the observation that the CI builders may be failing as Python will default to using the environment's setting to decode the file (which we expect to be in UTF-8). If the environment does not have `LC_ALL` set, it will use the fallback locale of `C` which is going to use ASCII. This results in the decoding failure. Convert the argument from `FileType` to `str` and use `io.open` to allow us to open the file with the correct encoding and line-ending irrespective of the Python version.
This changes the python interpreter used to invoke the tests to Python3. Python2 has been EOL'ed by the Python Software Foundation. This migration enables the Swift test suite to run with Python 3 instead.
compnerd
force-pushed
the
unicode-experimentation
branch
from
e98545f to
bf6134f
Compare
|
Please test with following PRs: @swift-ci please test Linux platform |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.