[Docs] Edits for educational note on PATs #33736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @theblixguy |
owenv
reviewed
Sep 1, 2020
Co-authored-by: Owen Voorhees <[email protected]>
slavapestov
reviewed
Sep 2, 2020
ferologics
reviewed
Sep 29, 2020
xwu
changed the title
|
@owenv I must have had higher ambitions initially for this revision when I left it as a draft, but as an incremental improvement, I think it's in a state that's worth landing; more can always be added later. WDYT? |
|
@swift-ci smoke test |
owenv
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some edits for the educational note on PATs, to accompany the educational note on existential types.
Initial changes are just some grammatical changes and edits to try to improve the text's flow, but @theblixguy points out an interesting issue over at #33735 that we should incorporate here.
Additionally, the restriction on using PATs as existential types may be easily lifted, but we will need to do an even better job of explaining why some APIs are missing, so this text will need to be fleshed out.