[TF] Add Optional: KeyPathIterable conformance.
#33992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `KeyPathIterable` conformances for `Optional` and `Optional.TangentVector`.
|
@swift-ci Please test tensorflow |
|
There are some unrelated test failures, to be investigated: Merging to unblock progress. |
dabrahams
pushed a commit
to google/swift
that referenced
this pull request
Sep 19, 2020
…tage * 'tensorflow' of github.com:apple/swift: [TF] Add `Optional: KeyPathIterable` conformance. (swiftlang#33992)
efremale
added a commit
to efremale/swift-apis
that referenced
this pull request
Sep 23, 2020
swiftlang/swift#33992 added `Optional: KeyPathIterable` conformance. The added conformance caused code parts like `self[keyPath: kp] as? _KeyPathIterableBase` to be interpreted as casting `Optional` (return type of `self[keyPath: kp]`) to `_KeyPathIterableBase` (which always succeeds because of the added conformance). The original intention was to cast the wrapped value of `Optional` to `_KeyPathIterableBase`. This original behavior is restored by changing `if let nested = self[keyPath: kp] as? _KeyPathIterableBase` to `if let value = self[keyPath: kp], let nested = value as? _KeyPathIterableBase`, where `value` first "unwraps" `Optional` and `nested` is the result of casting wrapped value to `_KeyPathIterableBase`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
KeyPathIterableconformances forOptionalandOptional.TangentVector.Unblocks tensorflow/swift-apis#1062.