Skip to content

[NFC] Remove a typealias from SILInstruction.h that's unused in noasserts builds. #34031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2020
Merged

[NFC] Remove a typealias from SILInstruction.h that's unused in noasserts builds. #34031

merged 1 commit into from
Sep 23, 2020

Conversation

hborla
Copy link
Member

@hborla hborla commented Sep 22, 2020

This was only used to shorten the lines in the assert, but all of the lines are under 80 columns anyway.

@hborla hborla requested a review from slavapestov September 22, 2020 18:42
@hborla
Copy link
Member Author

hborla commented Sep 22, 2020

@swift-ci please smoke test

slavapestov
slavapestov approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@slavapestov slavapestov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hborla
Copy link
Member Author

hborla commented Sep 22, 2020

@swift-ci please smoke test OS X Platform

1 similar comment
@hborla
Copy link
Member Author

hborla commented Sep 22, 2020

@swift-ci please smoke test OS X Platform

@hborla hborla merged commit 55144ab into swiftlang:master Sep 23, 2020
@hborla hborla deleted the unused-typealias-warning branch September 23, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hborla @slavapestov