Skip to content

WinSDK: extract Security submodule with winscard.h #34215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

egorzhdan
Copy link
Contributor

Currently winscard.h gets included into WinSDK.WinSock2 via windows.h.
This change extracts it into a separate submodule.
MSDN lists this header in https://docs.microsoft.com/en-us/windows/win32/api/_security/ along with authz.h & wincrypt.h, so this change also moves these submodules into Security.

Currently this header gets included into `WinSDK.WinSock2` via windows.h
@egorzhdan egorzhdan requested a review from compnerd October 7, 2020 12:18
@compnerd
Copy link
Member

compnerd commented Oct 7, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - 3708e7b

@compnerd
Copy link
Member

compnerd commented Oct 7, 2020

@swift-ci please smoke test macOS platform

@compnerd compnerd merged commit b51e212 into swiftlang:main Oct 7, 2020
@egorzhdan egorzhdan deleted the winsdk-security branch October 8, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants