Skip to content

Improve -*prefix-map help text #34228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

Improve -*prefix-map help text #34228

merged 1 commit into from
Oct 15, 2020

Conversation

keith
Copy link
Member

@keith keith commented Oct 7, 2020

Before:

-coverage-prefix-map <value>
-debug-prefix-map <value>

After:

-coverage-prefix-map <prefix=replacement>
-debug-prefix-map <prefix=replacement>

@keith
Improve -*prefix-map help text
ae0c380 
Before:

```
-coverage-prefix-map <value>
-debug-prefix-map <value>
```

After:

```
-coverage-prefix-map <prefix=replacement>
-debug-prefix-map <prefix=replacement>
```
@keith keith changed the title Improve -*prefix-map help text Improve -*prefix-map help text Oct 7, 2020
kastiglione
kastiglione reviewed Oct 8, 2020
View reviewed changes
Copy link
Contributor

@kastiglione kastiglione left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems great to me. The one thing I'd want to check is if the MetaVarName is consistent with others (are there any other key=value forms), and if it's used in places other than the help output, and if those need to be considered.

@kastiglione
Copy link
Contributor

@swift-ci smoke test

@keith
Copy link
Member Author

keith commented Oct 8, 2020

looks like the other examples are <path> <sdk> <n> and a few other similar ones.

@kastiglione
Copy link
Contributor

@swift-ci smoke test Linux Platform

1 similar comment
@kastiglione
Copy link
Contributor

@swift-ci smoke test Linux Platform

@kastiglione kastiglione merged commit d35cb3c into swiftlang:main Oct 15, 2020
@keith keith deleted the ks/improve--prefix-map-help-text branch October 15, 2020 19:40
@keith
Copy link
Member Author

keith commented Oct 15, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kastiglione kastiglione kastiglione approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith @kastiglione