Skip to content

Silence a Raft of Warnings from the Windows Build #34312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2020
Merged

Silence a Raft of Warnings from the Windows Build #34312

merged 4 commits into from
Oct 15, 2020

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Oct 14, 2020 •
edited
Loading

  • Silence unhandled control flow in switches
  • Use an explicit 64-bit shift where a 32-bit shift-then-convert was being applied
  • Cut over to FixedVectorType. I don't believe these were meant to be scalable vectors.

@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 14, 2020

@swift-ci test

compnerd
compnerd approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you so much for cleaning up the warning!

@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 15, 2020

⛵

@CodaFi CodaFi merged commit 476890c into swiftlang:main Oct 15, 2020
@CodaFi CodaFi deleted the just-keep-passing-the-open-windows branch October 15, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodaFi @compnerd