Verify that nil can cast to AnyHashable #34434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional conditionally conforms to Hashable, so for example `Optional<Int>` must cast to AnyHashable _even if it contains `nil`_. This was broken up through Swift 5.3 and was fixed by the new dynamic cast runtime. Add a test to ensure this stays fixed.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test Windows platform |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Oct 28, 2020
* 'main' of github.com:apple/swift: Verify that nil can cast to AnyHashable (swiftlang#34434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another case that was broken in Swift 5.3 and earlier but was
fixed by the new dynamic cast runtime.
Add a test to help ensure it stays fixed.