[Concurrency] Add a builtin to get the current task in an async function #34595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
…ion. This introduces a new builtin, `getCurrentAsyncTask()`, that produces a reference to the current task. This builtin can only be used within `async` functions, and IR generation merely grabs the task argument and packages it up. The type of this function is `() -> Builtin.NativeObject`, because we don't currently have a Swift-level representation of tasks, and can probably handle everything through builtins or runtime calls.
DougGregor
force-pushed
the
get-current-async-task-builtin
branch
from
0696ad4 to
55a3c83
Compare
Rather than produce an "unowned" result from `getCurrentAsyncTask()`, take advantage of the fact that the task is effectively guaranteed in the scope. Do so be returning it as "unowned", and push an end_lifetime cleanup to end the lifetime. This eliminates unnecessary ref-count traffic as well as introducing another use of unowned. Approach is thanks to Michael Gottesman, bugs are mine.
DougGregor
force-pushed
the
get-current-async-task-builtin
branch
from
55a3c83 to
ed9a548
Compare
gottesmm
reviewed
Nov 5, 2020
gottesmm
reviewed
Nov 5, 2020
Michael has ghostwritten all of this to address his own comments. Thank you!
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new builtin,
getCurrentAsyncTask(), that produces areference to the current task. This builtin can only be used within
asyncfunctions, and IR generation merely grabs the task argumentand packages it up.
The type of this function is
() -> Builtin.NativeObject, because wedon't currently have a Swift-level representation of tasks, and can
probably handle everything through builtins or runtime calls.