[AutoDiff] Fix crasher on property getter in library evolution mode. #34777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SILBuilder::createAllocStack` expects a debug variable when the location is a `VarDecl`. Since we are in pullbacks, there's no debug variables so we pass an empty one. General support for debug-info-in-pullbacks will be added as part of SR-13535. Also add negative tests for SR-13866. Resolves SR-13865.
|
@swift-ci please test |
joshnewnham
approved these changes
Nov 17, 2020
|
@swift-ci please test and merge |
|
Build failed |
|
@swift-ci please test macos platform and merge |
|
@swift-ci please test macos platform |
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Nov 17, 2020
* 'main' of github.com:apple/swift: [AutoDiff] Fix crasher on property getter in library evolution mode. (swiftlang#34777) [sil] Add a small helper to SILBuilder to get the loc of the builder's current insertion point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILBuilder::createAllocStackexpects a debug variable when the location is aVarDecl. Since we are in pullbacks, there's no debug variables so we pass an empty one.General support for debug-info-in-pullbacks will be added as part of SR-13535.
Also add a negative test for SR-13866.
Resolves SR-13865.