Skip to content

Importer: remove ImportAsMember inference support #34871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

Importer: remove ImportAsMember inference support #34871

merged 1 commit into from
Mar 23, 2021

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Nov 25, 2020 •
edited
Loading

This functionality is not actively in use and the last usage of this has
been removed. Remove the infrastructure that is no longer in need.

@compnerd
Copy link
Member Author

CC: @gribozavr @hlopko @scentini

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd requested review from gribozavr and CodaFi November 25, 2020 21:38
@CodaFi
Copy link
Contributor

CodaFi commented Nov 25, 2020

Unfortunately we cannot take this as is. I will reopen Dmitri’s PR when we can.

@compnerd
Copy link
Member Author

Converting to draft to prevent accidental merge

@compnerd compnerd marked this pull request as draft November 30, 2020 16:49
@compnerd
Copy link
Member Author

@CodaFi - I don't think that opening @gribozavr's PR would be as helpful, the tree has diverged, so this change is likely more useful at this point. Would you mind just converting this change to an open PR from draft when we can actually merge this change?

@CodaFi CodaFi marked this pull request as ready for review March 20, 2021 19:15
@CodaFi
Copy link
Contributor

CodaFi commented Mar 20, 2021

@compnerd Please rebase this, and let's get it merged. I want to commend you on your patience here - I know this was blocking good work you were doing elsewhere and I'm sorry it took so long to get the stars to align to make this happen.

@compnerd
Importer: remove ImportAsMember support
714eaef 
This functionality is not actively in use and the last usage of this has
been removed.  Remove the infrastructure that is no longer in need.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 714eaef

@compnerd
Copy link
Member Author

@swift-ci please test Linux platform

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@CodaFi
Copy link
Contributor

CodaFi commented Mar 23, 2021

⛵

@CodaFi CodaFi merged commit d6d9db3 into swiftlang:main Mar 23, 2021
@compnerd compnerd deleted the noiam branch March 23, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gribozavr gribozavr Awaiting requested review from gribozavr

@CodaFi CodaFi Awaiting requested review from CodaFi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @CodaFi @swift-ci