Skip to content

[CSBindings] Let producer record a binding for a hole #35044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2020
Merged

[CSBindings] Let producer record a binding for a hole #35044

merged 2 commits into from
Dec 14, 2020

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 10, 2020

As a step towards making binding inference more incremental, let's
make producer responsible for adding hole type binding instead of
doing so in finalize.

@xedin
[CSBindings] Let producer record a binding for a hole
22b34e8 
As a step towards making binding inference more incremental, let's
make producer responsible for adding hole type binding instead of
doing so in `finalize`.
@xedin xedin requested a review from hborla December 10, 2020 23:41
@xedin
Copy link
Contributor Author

xedin commented Dec 10, 2020

@swift-ci please test source compatibility

hborla
hborla approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xedin
Copy link
Contributor Author

xedin commented Dec 11, 2020

I'm going to push a small NFC cleanup to TypeVarBindingProducer and TypeVariableStep after source compat suite is done.

@xedin
Copy link
Contributor Author

xedin commented Dec 11, 2020

@swift-ci please clean test

@xedin
Copy link
Contributor Author

xedin commented Dec 11, 2020

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8e4207e

@xedin
Copy link
Contributor Author

xedin commented Dec 11, 2020

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8e4207e

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8e4207e

@xedin
Copy link
Contributor Author

xedin commented Dec 11, 2020

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented Dec 11, 2020

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8e4207e

@xedin
Copy link
Contributor Author

xedin commented Dec 11, 2020

@swift-ci please test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 8e4207e

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8e4207e

@xedin
Copy link
Contributor Author

xedin commented Dec 12, 2020

@swift-ci please clean test Linux platform

@xedin
Copy link
Contributor Author

xedin commented Dec 12, 2020

@swift-ci please clean test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8e4207e

@xedin
Copy link
Contributor Author

xedin commented Dec 14, 2020

@swift-ci please test macOS platform

@xedin xedin merged commit 296ab5f into swiftlang:main Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xedin @swift-ci @hborla