Skip to content

[swift-driver Incremental] Fix test to be more compatible with swift-driver #35087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 15, 2020
Merged

[swift-driver Incremental] Fix test to be more compatible with swift-driver #35087

merged 2 commits into from
Dec 15, 2020

Conversation

davidungar
Copy link
Contributor

  1. Fix a case where test is sensitive to "./", which is removed in the swift-driver.
  2. Since swift-driver outputs -driver-show-incremental as diagnostic remarks, fix tests to read stderr for those.

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar davidungar requested review from CodaFi and artemcm December 14, 2020 21:30
@davidungar
Copy link
Contributor Author

Thanks, @artemcm !

@davidungar davidungar merged commit 3c26585 into swiftlang:main Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@CodaFi CodaFi Awaiting requested review from CodaFi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidungar @artemcm