Skip to content

[android][test] Mark other-entry-point-function-name as executable. #35630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

drodriguez
Copy link
Contributor

The test other-entry-point-function-name needs to be executed to be
checked. Some platforms (like Android) do not execute the test in CI
(because there's no device attached to the build machines), so the tests
need to be marked as executable to be skipped.

The test was introduced in #35595 and started failing in CI in https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/9018/ and https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/7441/.

The test other-entry-point-function-name needs to be executed to be
checked. Some platforms (like Android) do not execute the test in CI
(because there's no device attached to the build machines), so the tests
need to be marked as executable to be skipped.
@drodriguez
Copy link
Contributor Author

@swift-ci please test and merge

Copy link
Contributor

@nate-chandler nate-chandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@swift-ci swift-ci merged commit e5800f1 into swiftlang:main Jan 28, 2021
@drodriguez drodriguez deleted the android-executable-entry-point branch February 2, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants