Skip to content

[github] Document what the macOS/Linux pull requests do in the PR tem… #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

What's in this pull request?

Resolved bug number: (SR-)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

…plate for easy access.

@gottesmm
Copy link
Contributor Author

@shahmishal How does this look?

@atrick
Copy link
Contributor

atrick commented Jul 19, 2016

Thanks!

I'm generally irritated with this though because the template does not actually work when you generate the PR (swift-ci options don't work at that point). Then I can never get back to the descriptions when I need them. How can I get access to this documentation without creating a fake PR?

@gottesmm
Copy link
Contributor Author

The PR template is located in .github/PULL_REQUEST_TEMPLATE

@gottesmm
Copy link
Contributor Author

I talked with Mishal via email and he is ok with this going in.

@gottesmm gottesmm merged commit 698028a into swiftlang:master Jul 19, 2016
@gottesmm gottesmm deleted the document_smoketests_in_pr_template branch July 19, 2016 18:35
kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022
Resolve conflicts with upstream `main`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants