[Build Script] Install libDispatch only after all builds are complete. #36428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot install libdispatch until after all builds are complete as that will cause the Dispatch module to be imported twice and fail to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot install libdispatch until after all builds are complete because if we do so, subsequently-built components that depend on dispatch will discover two instances of the
Dispatchmodule: one in its source directory, another installed in the toolchain, and fail to build.This came up now as we are attempting to version-bump Yums, for which the new version (4.0.2) introduces a dependency on Dispatch in its CMake build files.