Skip to content

[APIDigester] Allow outputting module diff diagnostics as JSON for other tools to consume #36435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Mar 14, 2021

The motivation behind this change is to begin experimenting with automatic semantic versioning suggestions for Swift packages. By serializing the kind of API change in addition to the diagnostic text, it gives tools which use the api digester a little more flexibility in how they interpret the output of a -diagnose-sdk action. The new behavior is gated behind the --json flag.

Example Output:

{
  "version": {
    "major": 0,
    "minor": 1
  },
  "diagnostics": [
    {
      "identifier": "declTypeChange",
      "text": "cake: Constructor S1.init(_:) has parameter 0 type change from Swift.Int to Swift.Double"
    },
    {
      "identifier": "funcSelfAccessChange",
      "text": "cake: Func S1.foo1() has self access kind changing from NonMutating to Mutating"
    },
...

@owenv
Copy link
Contributor Author

owenv commented Mar 14, 2021

@swift-ci please smoke test

@owenv owenv requested a review from nkcsgexi March 14, 2021 23:38
@owenv
Copy link
Contributor Author

owenv commented Mar 15, 2021

@swift-ci please test Windows

1 similar comment
@owenv
Copy link
Contributor Author

owenv commented Mar 16, 2021

@swift-ci please test Windows

@owenv owenv force-pushed the api-digester-json-diags branch from 6ce03c0 to dd69950 Compare March 23, 2021 04:18
@owenv
Copy link
Contributor Author

owenv commented Mar 23, 2021

@swift-ci please smoke test

@owenv owenv force-pushed the api-digester-json-diags branch from dd69950 to 8f94995 Compare March 24, 2021 02:03
@owenv
Copy link
Contributor Author

owenv commented Mar 24, 2021

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Mar 24, 2021

@swift-ci please smoke test Linux

@owenv owenv force-pushed the api-digester-json-diags branch from 8f94995 to f547583 Compare April 4, 2021 20:40
@owenv
Copy link
Contributor Author

owenv commented Apr 4, 2021

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Apr 4, 2021

@swift-ci please smoke test macOS

@owenv
Copy link
Contributor Author

owenv commented Apr 7, 2021

@swift-ci please test Windows platform

1 similar comment
@owenv
Copy link
Contributor Author

owenv commented Apr 8, 2021

@swift-ci please test Windows platform

@owenv owenv closed this May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant