TempRValueOpt: small fixes/improvements for extending access scopes #36564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more relevant instructions to dump in MemBehaviorDumper. Therefore the -enable-mem-behavior-dump-all option can be removed. Also mem-behavior-all.sil into mem-behavior.sil, because the sil-opt command lines don't differ anymore.
* ``begin_access [modify]`` returned MayWrite, but "modify" means, it can be a read as well. Instead, return MayReadWrite. Only for ``begin_access [init]`` return MayWrite. This is more or less cosmetic - probably this bug had no real impact on any optimization. * ``begin_access [deinit]`` needs to return MayReadWrite for the same reason ``destroy_addr`` returns MayReadWrite (see SILInstruction::MemoryBehavior).
Don't move an end_access over a (non-aliasing) end_access. This would destroy the proper nesting of accesses. Also, add some comments, asserts and tests.
|
@swift-ci test |
|
Build failed |
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't move an end_access over a (non-aliasing) end_access. This would destroy the proper nesting of accesses.
Also, add some comments, asserts and tests.
This is a follow-up of #36540
Also, fix minor bugs for
begin_accessandend_accessin MemBehavior and clean-up the membehavior tests.