Skip to content

Remap aarch64_32 to arm64_32 When Searching for Modules #37118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Apr 28, 2021

The triple name aarch64_32 does not actually name a valid platform. The
actual platform (and valid triple arch string, confusingly enough) is
arm64_32. Remap between the two to correct for this difference.

rdar://77281393

@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 28, 2021

@swift-ci smoke test

@CodaFi CodaFi force-pushed the triple-sec branch 2 times, most recently from 2a199b7 to 7cefa9c Compare April 28, 2021 20:47
@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 28, 2021

@swift-ci smoke test

@xymus
Copy link
Contributor

xymus commented Apr 28, 2021

@CodaFi Can you also reenable test/ClangImporter/nested_protocol_name.swift to fix that Radar?

ref 237610e5b68

@xymus
Copy link
Contributor

xymus commented Apr 28, 2021

as well as test/IDE/print_clang_header.swift and test/IDE/print_clang_header_swift_name.swift to close rdar://77281884.

ref a5440a8abd8

The triple name aarch64_32 does not actually name a valid platform. The
actual platform (and valid triple arch string, confusingly enough) is
arm64_32. Remap between the two to correct for this difference.

rdar://77281393
@CodaFi
Copy link
Contributor Author

CodaFi commented Apr 29, 2021

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 910a741 into swiftlang:main Apr 29, 2021
@CodaFi CodaFi deleted the triple-sec branch April 29, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants