Skip to content

Allow functions marked @LLDBDebuggerFunction to bypass actor isolatio… #37198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2021

Conversation

adrian-prantl
Copy link
Contributor

…n checks

In order to allow LLDB to evaluate expressions inside an actor without spawining
async functions and potentially continue all threads, this relaxes the actor
isolation checks in @LLDBDebuggerFunction functions to allow a synchronous call
into an extension method.

rdar://75905336
(cherry picked from commit 93449728b9b7aaf84ad69ed1d0d7785cd825e0d6)

…n checks

In order to allow LLDB to evaluate expressions inside an actor without spawining
async functions and potentially continue all threads, this relaxes the actor
isolation checks in @LLDBDebuggerFunction functions to allow a synchronous call
into an extension method.

rdar://75905336
(cherry picked from commit 93449728b9b7aaf84ad69ed1d0d7785cd825e0d6)
@adrian-prantl adrian-prantl requested a review from DougGregor May 1, 2021 02:21
@adrian-prantl
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

swift-ci commented May 1, 2021

Build failed
Swift Test OS X Platform
Git Sha - 2a01301

@xymus
Copy link
Contributor

xymus commented May 1, 2021

@swift-ci Please test macOS

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks.

@adrian-prantl adrian-prantl merged commit 3a36baf into swiftlang:release/5.5 May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants