[5.5][Refactoring] When adding an async alternative refactor the old method to call the async method using detach #37203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
ahoppen
force-pushed
the
pr-5.5/legacy-async-method-refactor
branch
from
ee2b81e to
be85d81
Compare
…ks that the code compiles after refactoring
…d to call the async method using detach Instead of leaving two copies of the same implementation, rewrite the old method with the completion handler to call the newly added `async` method. Resolves rdar://74464833
ahoppen
force-pushed
the
pr-5.5/legacy-async-method-refactor
branch
from
be85d81 to
2878ab4
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
In `main` this method was added by 9ed732f. Since that commit is rather large, only cherry-pick the `isOptional` method to 5.5.
|
@swift-ci Please test |
|
Build failed |
akyrtzi
approved these changes
May 5, 2021
|
@swift-ci Please test macOS |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks #37185 to 5.5.
Instead of leaving two copies of the same implementation, rewrite the old method with the completion handler to call the newly added
asyncmethod.Also add a tool
%refactor-check-compileswhich is a drop-in replacement for%refactorand verifies that the refactored code actually compiles.Resolves rdar://74464833