Skip to content

[Test] Fix Runtime/protocol_conformance_collision.swift on 11.3+. #37257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented May 4, 2021

This test checks the OS version to decide how to operate but that check isn't right. Revert to a fake future version.

rdar://77389722

This test checks the OS version to decide how to operate but that check isn't right. Revert to a fake future version.

rdar://77389722
@mikeash mikeash requested a review from shahmishal May 4, 2021 19:30
@mikeash
Copy link
Contributor Author

mikeash commented May 4, 2021

@swift-ci please smoke test

@mikeash
Copy link
Contributor Author

mikeash commented May 4, 2021

@swift-ci please smoke test windows platform

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Mike!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants