Skip to content

[5.5] Visit ForEachStmt in source order in SemaAnnotator #37761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

hamishknight
Copy link
Contributor

A narrower version of #37760 that only touches the SemaAnnotator walking logic.

rdar://78781061

A narrower fix for rdar://78781061 that only touches
the SemaAnnotator walking logic.

rdar://78781061
@hamishknight hamishknight requested a review from a team as a code owner June 3, 2021 10:29
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight requested review from bnbarham and akyrtzi June 3, 2021 10:30
Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable in order to keep it constricted to lib/IDE only, I would hope there isn't anything relying on the where being visited before the sequence in general though 🤷.

@akyrtzi akyrtzi merged commit 221d81e into swiftlang:release/5.5 Jun 4, 2021
@hamishknight hamishknight deleted the walk-this-way-5.5 branch June 4, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants