Skip to content

[Stdlib] Move SwiftNativeNSObject to libswiftCore. #37954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Jun 16, 2021

This type can be put to good use outside of the concurrency runtime. Reexport it from libswift_Concurrency so it can still be found there as well.

rdar://79352061

@mikeash mikeash requested a review from DougGregor June 16, 2021 20:23
@mikeash
Copy link
Contributor Author

mikeash commented Jun 16, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b70c3329c1882917cba7cc6f6fe07ea7b6a09490

This type can be put to good use outside of the concurrency runtime. Reexport it from libswift_Concurrency so it can still be found there as well.

rdar://79352061
@mikeash
Copy link
Contributor Author

mikeash commented Jun 16, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b70c3329c1882917cba7cc6f6fe07ea7b6a09490

@mikeash mikeash force-pushed the move-SwiftNativeNSObject branch from b70c332 to 25b42b5 Compare June 17, 2021 00:06
@mikeash
Copy link
Contributor Author

mikeash commented Jun 17, 2021

@swift-ci please test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@mikeash mikeash merged commit a77a277 into swiftlang:main Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants