Skip to content

[5.5] Fix taskWait function family calls on arm64e #37985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2021
Merged

[5.5] Fix taskWait function family calls on arm64e #37985

merged 1 commit into from
Jun 23, 2021

Conversation

aschwaighofer
Copy link
Contributor

@aschwaighofer aschwaighofer commented Jun 18, 2021 •
edited
Loading

The function pointer we pass to the task_wait functions needs to be
signed.

rdar://79561582

@aschwaighofer
[5.5] Fix taskWait function family calls on arm64e
96be1e0 
The function pointer we pass to the task_wait functions needs to be
signed.
@aschwaighofer aschwaighofer requested a review from a team as a code owner June 18, 2021 20:50
@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test

@aschwaighofer
Copy link
Contributor Author

main PR: #37984

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci please test linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci Please test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@angela-laar
Copy link
Contributor

@swift-ci please smoke test macOS

@shahmishal
Copy link
Member

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@aschwaighofer
Copy link
Contributor Author

The macOS failure is unrelated to this PR:

Exit Code: 134

Command Output (stdout):
--
[ RUN      ] new SDK protocol conformance collision.CFString: Hashable conformance
[       OK ] new SDK protocol conformance collision.CFString: Hashable conformance
new SDK protocol conformance collision: All tests passed
[ RUN      ] old SDK protocol conformance collision.CFString: Hashable conformance
stdout>>> check failed at /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-release/5.5/swift/test/Runtime/protocol_conformance_collision.swift, line 66
stdout>>> expected: 1 (of type Swift.Int)
stdout>>> actual: 0 (of type Swift.Int)
[     FAIL ] old SDK protocol conformance collision.CFString: Hashable conformance
old SDK protocol conformance collision: Some tests failed, aborting
UXPASS: []
FAIL: ["CFString: Hashable conformance"]
SKIP: []
To debug, run:
$ /Users/buildnode/jenkins/workspace/swift-PR-macos/branch-release/5.5/buildbot_incremental/swift-macosx-x86_64/test-macosx-x86_64/Runtime/Output/protocol_conformance_collision.swift.tmp/oldSDK --stdlib-unittest-in-process --stdlib-unittest-filter "CFString: Hashable conformance"

jckarter
jckarter approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Arnold!

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@aschwaighofer
Copy link
Contributor Author

@swift-ci test macOS

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96be1e0

@shahmishal shahmishal merged commit f40d349 into swiftlang:release/5.5 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter jckarter approved these changes

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aschwaighofer @swift-ci @angela-laar @shahmishal @jckarter @DougGregor